fix(player): keep capture dialog dismissible via outside tap - #948
Merged
MCDFsteve merged 1 commit intoSep 28, 2026
Merged
Conversation
On tablet-like devices during fullscreen playback (hidden control bar) the media capture dialog disabled barrier dismissal, leaving the top-right close button as the only way to close it. Pass barrierDismissible: true unconditionally so tapping outside the dialog closes it, consistent with other Nipaplay windows.
FurudeRika123
approved these changes
Sep 27, 2026
FurudeRika123
left a comment
Member
There was a problem hiding this comment.
Reviewed the change.
Passing barrierDismissible: true unconditionally for the media capture dialog keeps outside-tap dismissal consistent with the other dialogs on this page, and _shouldDisableDialogDismiss() stays in use by _showAirPlayPicker(), so the helper is not left dead. Change is small and scoped; LGTM.
One note for the record: Analyze and Test is currently red on this head SHA, but the failure is test/television_media_library_test.dart: media collection restores each source sort after switching sections, which also fails on unrelated PRs — it is not caused by this diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
barrierDismissible: trueunconditionally so tapping outside the dialog closes it, consistent with other Nipaplay windows: the desktopNipaplayWindowScaffoldbackground tap handler and the phone bottom sheet barrier already support outside-tap dismissal.What Changed
lib/pages/play_video_page.dart:_showMediaCaptureSettingsnow always passesbarrierDismissible: truetoshowMediaCaptureDialoginstead of gating on_shouldDisableDialogDismiss.Verification
flutter analyze --no-fatal-infos --no-fatal-warnings lib/pages/play_video_page.dart: no new issues (3 pre-existing info-level hints in untouched code).flutter test --no-pub test/media_capture_dialog_input_test.dart: 3/3 passed.