Skip to content

fix(player): keep capture dialog dismissible via outside tap - #948

Merged
MCDFsteve merged 1 commit into
AimesSoft:mainfrom
TsangAsuna:fix/capture-dialog-outside-dismiss
Sep 28, 2026
Merged

MCDFsteve merged 1 commit into
AimesSoft:mainfrom
TsangAsuna:fix/capture-dialog-outside-dismiss

Conversation

@TsangAsuna

Copy link
Copy Markdown
Contributor

Summary

  • On tablet-like mobile devices during fullscreen playback (control bar hidden), the media capture dialog (opened by tapping or long-pressing the screenshot button) disabled barrier dismissal, leaving the top-right close button as the only way to close the dialog.
  • Pass barrierDismissible: true unconditionally so tapping outside the dialog closes it, consistent with other Nipaplay windows: the desktop NipaplayWindowScaffold background tap handler and the phone bottom sheet barrier already support outside-tap dismissal.

What Changed

  • lib/pages/play_video_page.dart: _showMediaCaptureSettings now always passes barrierDismissible: true to showMediaCaptureDialog instead of gating on _shouldDisableDialogDismiss.

Verification

  • flutter analyze --no-fatal-infos --no-fatal-warnings lib/pages/play_video_page.dart: no new issues (3 pre-existing info-level hints in untouched code).
  • flutter test --no-pub test/media_capture_dialog_input_test.dart: 3/3 passed.

On tablet-like devices during fullscreen playback (hidden control
bar) the media capture dialog disabled barrier dismissal, leaving
the top-right close button as the only way to close it. Pass
barrierDismissible: true unconditionally so tapping outside the
dialog closes it, consistent with other Nipaplay windows.
@TsangAsuna
TsangAsuna requested a review from a team as a code owner September 26, 2026 16:21

@FurudeRika123 FurudeRika123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the change.

Passing barrierDismissible: true unconditionally for the media capture dialog keeps outside-tap dismissal consistent with the other dialogs on this page, and _shouldDisableDialogDismiss() stays in use by _showAirPlayPicker(), so the helper is not left dead. Change is small and scoped; LGTM.

One note for the record: Analyze and Test is currently red on this head SHA, but the failure is test/television_media_library_test.dart: media collection restores each source sort after switching sections, which also fails on unrelated PRs — it is not caused by this diff.

@MCDFsteve
MCDFsteve merged commit d749acc into AimesSoft:main Sep 28, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants