fix(ohos): align alpha bindings, C headers and API docs - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenHarmony discarded
videoAlphaModebefore presenter creation, so transparent video requests always used opaque mode. Forward the optional parameter through both Flutter and standalone OHPM bindings, retaining the three-argument default.Synchronize the OHPM header mirror and correct English, Chinese and Japanese API documentation, including synchronous open behavior, Windows texture ownership and the v0.1.8 configuration ABI change. Add focused header/signature checks and execute both native creation functions with a fake N-API host to verify forwarding and legacy behavior.
Validation: five focused tests pass; the unmodified v0.1.8 native functions fail the new alpha assertion. Workflow actionlint and whitespace checks pass. The v0.1.8 OHOS runtime exports all 96 expected C symbols. Device rendering is not verified.
The manual OHPM workflow can also build the Flutter bridge while reusing the existing v0.1.8 core. It saves the bridge and matching source as separate artifacts. Version numbers and existing release assets stay unchanged. The maintainer requested a narrow rebuild, so automatic matrices are skipped for this merge; the targeted OHOS package workflow will run explicitly.