feat(en.mangakakalot): add base url selection - #692
Merged
kkantan merged 4 commits intoAug 12, 2026
Conversation
- read the url setting in params(), falling back to mangakakalot.gg - set minAppVersion to 0.7.1 so aidoku verify passes - add tests for listings, search, details and page list
kkantan
approved these changes
Aug 12, 2026
| assert!(attempt < 3, "no entries after {attempt} attempts"); | ||
| sleep(10); | ||
| } | ||
| unreachable!() |
Contributor
There was a problem hiding this comment.
this code seems odd. why do you wait 3s before initializing a source? why is this marked unreachable even though it is reachable? I won't block the merge since testing code doesn't really matter, but I feel as though there are many better ways to write the things you have here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mangakakalot.ggserves a Cloudflare managed challenge (403,cf-mitigated: challenge)on every content path while the home page loads normally, so the Home tab works and every
listing, search and series page fails issue
The challenge is applied per client, not per path: a web view is served the real page, so no
cf_clearanceis ever issued for the source's own requests to reuse. That isAidoku/Aidoku#1034 and can't be fixed from here.
mangakakalove.comis already listed as this source's second url and serves all of thosepaths normally, so this makes it selectable.
Related: #1034, maybe related: #310
Changes
allowsBaseUrlSelectand leverage the alternate url.params(), falling back tomangakakalot.ggwhen unset, so thedefault is unchanged.
minAppVersionto0.7.1, without whichaidoku verifyfails its api version check.Testing
cargo build --release,cargo fmt,cargo clippy,aidoku package,aidoku verifyandcargo test -- --test-threads=1all pass. The tests hit the live site and need a singlethread, since the test runner ignores
set_rate_limit.Checked on device: listings, search, details and pages all load with
mangakakalove.comselected; switching back to the default reproduces the failure.