chore(release): resolve uuid < 11.1.1 everywhere, SHA-pin CI actions - #46
chore(release): resolve uuid < 11.1.1 everywhere, SHA-pin CI actions#46syedhassan-aifinpay wants to merge 1 commit into
Conversation
|
Reviewed. LGTM. uuid — this is a lockfile bump, and it goes up, not down: mcp rc.3 → rc.4 is required, not cosmetic. The agent bump is the opposite case. Version collision with #40Verified by test-merging both heads: the only conflicting file is Whoever merges second edits one line: One question, not a finding
I checked whether the currently published |
…ctions to SHAs
All eight open Dependabot alerts on this repository were the same finding:
uuid < 11.1.1 (missing buffer bounds check in v3/v5/v6), reached transitively
through @solana/web3.js → jayson → uuid@8.3.2 in every package that installs
the Solana client. jayson only calls v4, so the vulnerable code path is not
reachable from anything here — but "not reachable" is an argument that has to
be re-made every time someone reads the alerts page, and an alert that stays
open for a known-safe reason teaches people to stop reading it.
Each install root now carries `"overrides": { "uuid": "^11.1.1" }` and its
lockfile resolves uuid@11.1.1 (rpc-websockets already pulled 14.0.1). node,
wallet and mcp build and pass their suites unchanged: 155, 13 and 74 tests.
package.json is a published file, so the version gate requires a bump:
@aifinpay/agent 2.0.0-rc.2 → rc.3, @aifinpay/mcp patch. Note for the
main↔dev reconcile: sdk PR #40 on dev also bumps agent to rc.3 with different
content; whichever lands second takes rc.4. The gate exists to make exactly
that collision visible rather than silent.
GitHub Actions are pinned to commit SHAs with the tag in a trailing comment.
A moving tag is a supply-chain input into a pipeline that publishes a payment
SDK; a SHA is not. Closes the MEDIUM "CI dependencies/actions are not fully
immutable" from the 27 Aug audit.
47d2357 to
a1a91e7
Compare
The published-files gate is right: unifiedAgent.ts ships to users, so two different builds must not both call themselves rc.3. rc.6 rather than rc.4 on purpose. rc.4 is claimed by #46 and rc.5 by #49, both still open. Taking the next number above every open claim means this can merge in any order without making anyone renumber — and a royalty fix should not wait on a release-numbering negotiation.
Release-engineering items from the 27 Aug audit that need no decision, done before the next audit.
All 8 open Dependabot alerts were one finding:
uuid < 11.1.1reached transitively via@solana/web3.js → jayson → uuid@8.3.2in every install root. jayson only callsv4, so the vulnerable v3/v5/v6 path isn't reachable from here — but an alert left open for a known-safe reason teaches people to stop reading the page. Each install root now carriesoverrides: { uuid: "^11.1.1" }; every lockfile resolvesuuid@11.1.1.Unchanged suites: node 155, wallet 13, mcp 74.
Versions:
package.jsonis published, so the gate requires a bump —@aifinpay/agentrc.3 → rc.4 (rebased onto main after #40 landed as rc.3),@aifinpay/mcprc.3 → rc.4.Actions pinned to commit SHAs (tag in trailing comment). Closes the MEDIUM "CI dependencies/actions are not fully immutable".
Targets
mainbecause it is the release baseline and carries #42. Nothing here touches settlement code.