Conversation
I added this to SwingSet/package.json in commit d4bc617 (PR #3136). However I overlooked the fact that #3100 had already landed, which changed the top-level `yarn test` from one that just did a (sequential) `yarn workspaces test`, testing one package at a time with whatever the local `package.json` said to do, to one that does a (parallel) `ava` invocation, which does all packages at the same time but ignores the local `package.json` settings. We need to include `--expose-gc` in the `nodeArguments` in the top-level package.json to make sure the parallel form give the correct arguments when SwingSet's turn comes around (as well as other packages which benefit from enabling GC but don't have tests which directly assert that it can be done).
Member
Author
|
BTW, this snuck past because CI doesn't do a top-level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this to SwingSet/package.json in commit
d4bc617 (PR #3136). However I overlooked the
fact that #3100 had already landed, which changed the top-level
yarn testfrom one that just did a (sequential)
yarn workspaces test, testing onepackage at a time with whatever the local
package.jsonsaid to do, to onethat does a (parallel)
avainvocation, which does all packages at the sametime but ignores the local
package.jsonsettings.We need to include
--expose-gcin thenodeArgumentsin the top-levelpackage.json to make sure the parallel form give the correct arguments when
SwingSet's turn comes around (as well as other packages which benefit from
enabling GC but don't have tests which directly assert that it can be done).
Running a top-level
yarn teston agoric-sdk trunk is currrently broken because of this.