[16.0][ADD] agx_sarabun_user_template: user-defined route templates - #1233
Open
n3n wants to merge 2 commits into
Open
[16.0][ADD] agx_sarabun_user_template: user-defined route templates#1233n3n wants to merge 2 commits into
n3n wants to merge 2 commits into
Conversation
n3n
force-pushed
the
16.0-add-sarabun_route_template_user
branch
from
September 7, 2026 15:26
f33635d to
60aa98f
Compare
…ADR-0016) Let regular sarabun users create personal/unit-scoped route templates alongside the manager-only public catalogue, via owner_id + visibility on sarabun.route.template and matching ir.rules. Bundles chatter and a description field onto the core template model in agx_sarabun. Fixes review findings: dynamic visibility default (superuser/manager seed as public, regular users as personal) with the public-visibility constraint skipped for su, so bridge module seed data installs cleanly; requires department_id when visibility=unit.
n3n
force-pushed
the
16.0-add-sarabun_route_template_user
branch
from
September 7, 2026 17:49
60aa98f to
f59f65a
Compare
Collapse the parallel Configuration (manager-only) and root ("My
Templates") menus into a single top-level "แม่แบบเส้นทางอนุมัติ" entry
reachable by both roles. Rows are scoped per user by the existing read
ir.rule and the create-default (personal for users, public for managers)
comes from _default_visibility, so the default_visibility context
override is dropped and the old Configuration menu is deactivated
(xmlid preserved).
Updates ADR-0016 with a revision note and CONTEXT.md with the new label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agx_sarabun_user_templatemodule lets regular sarabun users own personal/unit-scoped route templates alongside the manager-only public catalogue, viaowner_id+visibilityonsarabun.route.templateand matching ir.rules (ADR-0016).agx_sarabuncore gains chatter (mail.thread/mail.activity.mixin) and a surfaceddescriptionfield on the template form, bundled with a manifest version bump (5.1.0 → 5.2.0).visibilitydefault is now dynamic (superuser/manager →public, regular users →personal) with the public-visibility constraint skipped underenv.su, so bridge-module seed data installs cleanly;visibility='unit'now requiresdepartment_id.Test plan
oca_run_testsforagx_sarabunandagx_sarabun_user_templateagx_sarabun_user_templateplus the route-template-seeding bridge modules on a clean DBpersonal