Skip to content

[16.0][FIX] agx_approval_operating_unit_access_all: restore user-bypass in OU ir.rules - #1202

Open
n3n wants to merge 2 commits into
16.0from
16.0-fix-agx-approval-ou-visibility
Open

[16.0][FIX] agx_approval_operating_unit_access_all: restore user-bypass in OU ir.rules#1202
n3n wants to merge 2 commits into
16.0from
16.0-fix-agx-approval-ou-visibility

Conversation

@n3n

@n3n n3n commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • The domain_force overwrite in agx_approval_operating_unit_access_all silently dropped the owner_id.user_id/user_id bypass conditions from the original agx_approval_operating_unit rules.
  • After an admin moves a user to a different OU, that user's old requests (with the old operating_unit_id) were no longer visible because only OU-membership was checked.
  • Fix restores the user-bypass conditions for all 4 rules: approval.request uses owner_id/user_id directly; child models (line/participant/allocation) use request_id.owner_id.user_id/request_id.user_id.
  • Bumped version to 16.0.1.0.1.

Test plan

  • Create an approval request as User A assigned to OU1
  • Move User A to OU2 (remove from OU1, add to OU2)
  • Verify User A can still see their previously created requests
  • Verify users with group_all_ou_approval_request still see all OUs' requests

n3n added 2 commits August 28, 2026 00:53
…OU rules

The domain_force overwrite dropped the owner/user conditions, hiding the
requester's own requests after an OU move. Restore them for all 4 rules
(request uses owner_id directly; line/participant/allocation use request_id prefix).
@n3n
n3n force-pushed the 16.0-fix-agx-approval-ou-visibility branch from 5468937 to 42ce953 Compare August 27, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant