[16.0][FIX] purchase_request_approval: report count + require title & vendor - #1195
Open
PiyaChaiyanit wants to merge 2 commits into
Open
[16.0][FIX] purchase_request_approval: report count + require title & vendor#1195PiyaChaiyanit wants to merge 2 commits into
PiyaChaiyanit wants to merge 2 commits into
Conversation
added 2 commits
August 24, 2026 15:00
…eport count, PA title, vendor required - report_purchase_request_approval: replace hardcoded "1 รายการ" with dynamic len(o.line_ids). - PA title becomes PA-owned: drop title from _prepare_approval_vals so it no longer copies from PR, and mark title required in the form. - purchase_request_procurement_mode: require vendor when procurement_mode = by_requester (ขอระบุเอง).
…ault, report stray marker, prepaid hint - purchase_request_approval: default PA title to "รายงานขอซื้อ/จ้าง". - report_purchase_request_approval: remove stray "-->" after the เอกสารคุณสมบัติ list item. - purchase_request_kmitl: shorten prepaid vendor hint translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
จำนวน 1 รายการwithlen(o.line_ids)so it reflects the true line count inreport_purchase_request_approval.xml.เรื่อง(title): droptitlefrom_prepare_approval_valsso it no longer auto-copies frompurchase.request, and mark itrequired="1"on the PA form — force users to enter it themselves.procurement_mode = by_requester: extend thepartner_idattrs inpurchase_request_procurement_modeto require the vendor when the user picks "ขอระบุเอง".Test plan
len(line_ids).เรื่องis empty and cannot be saved until filled; return-for-edit + resume does not overwrite an edited PA title.