[16.0][ADD] agx_sarabun_signature_title: prepend academic/job title to signature block - #1165
Open
n3n wants to merge 1 commit into
Open
[16.0][ADD] agx_sarabun_signature_title: prepend academic/job title to signature block#1165n3n wants to merge 1 commit into
n3n wants to merge 1 commit into
Conversation
…o signature block Phase-2 bridge module that captures academic_standing_title at signing (snapshot) and renders it before the signer's name on the endorsement block PDF — e.g. (ศาสตราจารย์ ดร. สมชาย ใจดี).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agx_sarabun_signature_title(phase-2 ofagx_sarabundesign) that prepends the signer's full academic or job title to the name line in the endorsement block PDF.signed_academic_titlesnapshot field onsarabun.routing.step, captured at signing time so later HR promotions never rewrite an already-signed หนังสือ (ADR-0009 pattern).agx_sarabun.sarabun_endorsement_blockvia QWeb XPath to replace the bare name span withsig._signed_display_name(), rendering e.g.(ศาสตราจารย์ ดร. สมชาย ใจดี).agx_sarabunandhr_employee_academic_standing_thailand; empty titles (no role match) are a no-op.วิธีทดสอบ
-i agx_sarabun_signature_title -u agx_sarabunบน dev DBhr.employeeให้role = academic,academic_standing_id = ศ., ระดับการศึกษา = ปริญญาเอก พร้อมผูก user และ signature imagesarabun.document→ ส่ง → ลงนามผ่าน verb ที่show_signature = True→ พิมพ์ PDF → ชื่อในบล็อกลงนามต้องแสดง(ศาสตราจารย์ ดร. ชื่อ-สกุล)role = support) → ชื่อต้องแสดง prefix ตำแหน่งงาน+ระดับตำแหน่งacademic_standing_idของพนักงาน → พิมพ์เอกสารเดิมซ้ำ → ชื่อที่พิมพ์ต้องไม่เปลี่ยน (อ่านจากsigned_academic_titlesnapshot)