Feat/detect hotspot capabiliteis#12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds hotspot capability detection based on the actual capabilities reported by NetworkManager.
Previously, wiretray assumed that any Wi-Fi adapter could be used for hotspot creation. In reality, not all wireless adapters support Access Point (AP) mode, which could lead to incorrect capability reporting and failed hotspot creation attempts.
What's included
Access Point capability detection
WirelessCapabilitiesfrom NetworkManager.DeviceCapabilitiesto model adapter capabilities.Device::supports_hotspot()helper.Improved hotspot capability validation
Device information in Settings
Added a new Device Information page to the settings window.
Displays:
This provides users with visibility into whether their hardware is capable of creating hotspots.
Why
Different Wi-Fi adapters expose different capabilities.
By detecting AP support directly from NetworkManager, wiretray can provide more accurate validation, better user feedback, and a stronger foundation for future hotspot configuration features.