Repository navigation
fix: stop defaulting to retired agentskit.io hosts - #1847
Closed
EmersonBraun wants to merge 4 commits into
Closed
EmersonBraun wants to merge 4 commits into
EmersonBraun wants to merge 4 commits into
Conversation
The ask.agentskit.io host is retired. The Ask widgets in docs-next and registry now render only when NEXT_PUBLIC_ASK_ENDPOINT is set instead of falling back to the dead host. E2E builds set a placeholder endpoint and the specs mock it. Backend README and RFC 0007 note the retirement. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Lighthouse
Run by |
Member
Author
|
Superseded by #1848 (same tree; commit message rewrapped for commitlint without force-push). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask.agentskit.iois retired and its DNS is about to be deleted. This removes the code defaults that still pointed at it.apps/registry/components/ask-widget.tsx): no longer falls back tohttps://ask.agentskit.io/v1/ask. It renders only whenNEXT_PUBLIC_ASK_ENDPOINTis set.apps/docs-next/app/(home)/layout.tsx,app/docs/layout.tsx): passesNEXT_PUBLIC_ASK_ENDPOINTexplicitly and renders only when it is set. This also matches the companion agentskit-chat change, wherecreateAskAdapterrequiresendpoint.apps/registry/.env.example:NEXT_PUBLIC_ASK_ENDPOINTis now empty, with a note that the widget is disabled when unset.apps/ask-backend/README.md,apps/registry/README.md, RFC 0007: say the host is retired and that sites configure the backend throughNEXT_PUBLIC_ASK_ENDPOINT. The RFC's historical body is unchanged; I added an update note at the top.NEXT_PUBLIC_ASK_ENDPOINT=https://ask.e2e.invalid/v1/ask, and the Playwright specs route that URL instead of the retired host.Behaviour change
NEXT_PUBLIC_ASK_ENDPOINTis now required for the docs and registry Ask widgets. When it is unset, both widgets are disabled (not rendered). Nothing was deleted.Checks
pnpm install --frozen-lockfile,pnpm lint(60/60): passpnpm test: pass, except two tests that hit the 5s vitest timeout under parallel load. Both are unrelated to this change and pass on rerun:@agentskit/netratchet: passes with a longer timeout@agentskit/sveltemanifest test: passed in an earlier runpnpm check:readme-standard,pnpm test:readme-standard,pnpm docs:bridge:gate: passpnpm test:e2e: not run locally; left to CIgit grepfor retired hosts: only historical records remain (RFC 0007 body plus its update note, the ask-backend README note saying the host is retired, and the generated doc-bridge index)