Repository navigation
docs: a bundle records a retargeted overlay patch, and fluid validate --strict fails on it (forge-cli #735) - #158
Merged
Merged
Conversation
… --strict fails on it (forge-cli #735)
1 of 3 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs for forge-cli #735. Merge it after that PR.
fluid bundle --env --format tgzrecords a retargeted overlay patch (overlay_patch_retargeted) in the bundle's manifest assource.overlayWarnings.fluid validate <bundle>.tgzreports it as anOVERLAY-WARNINGfinding, so--strictfails on it. Pipeline stage 2 runs exactly that command.Every new statement is marked (unreleased, forge-cli #735).
docs/cli/validate.md--envand environment overlays" now says a bundle carries the warning, and thatcontract-validationandtestdo not read the record. "Validating a bundle" has these additions: an "overlay warnings" item under "What it checks"; a--strictoutput example; the new pass and--quietoutput; andOVERLAY-WARNINGin the codes table.docs/cli/bundle.mdsource.overlayWarningsrow in the MANIFEST table, and one sentence noting thatfluid validatereports the record, escaped.docs/concepts/environments-and-overlays.mdoverlay_patch_retargetedbullet says a bundle carries it too.The output block is copied from the CLI on the #735 branch.
Checks (local)
scripts/check_cli_docs.pywas run against the local forge-cli (#735 branch). All 1,333 documentedfluidinvocations match, and the subcommand, quickstart, contract-pin and version-sweep checks are OK. The pin check fails only because that CLI is a dev build, not 0.18.1.scripts/check_providers.py: OK.npm run docs:build, thennode scripts/check-dist-links.mjs: clean (137,867 references, 242 pages).