test: fact-lifecycle edge cases for validFactsBeforeSession - #10
Draft
LaloLalo1999 wants to merge 2 commits into
Draft
LaloLalo1999 wants to merge 2 commits into
LaloLalo1999 wants to merge 2 commits into
Conversation
Adds memswe-fact-lifecycle.test.ts covering branches the existing valid-facts test does not exercise: - numeric (not lexical) session ordering: s9 < s10 < s100 - invalid_after_session expiry boundary - forget_requested_session exclusion boundary - forbidden / text-less fact exclusion - empty/absent introduce list Pure-function tests over synthetic tasks (no FS, no mocks). 7/7 green.
|
Mention Blocks like a regular teammate with your question or request: @blocks review this pull request Run |
…e-pi-d755e260b01d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
memswe-fact-lifecycle.test.ts— focused unit tests forvalidFactsBeforeSession/ session-ordering helpers inmemswe-smoke-runner-lib.ts.Why
The existing
memswe-valid-facts-before-session.test.ts(AMB-58) only checks inclusion at s1/s2/s3/s4 via task fixtures. It never exercises:sessionIndexdoesNumber(), sos9 < s10 < s100. A naive string compare would regress this silently.invalid_after_sessionexpiry boundary (valid at the boundary, dropped after).forget_requested_sessionexclusion boundary.expected_use: forbidden/ text-less fact exclusion.introducelist.How
Pure-function assertions over synthetic
TaskYamlobjects — no FS, no mocks, no fixtures to drift. 7/7 green againstmain(8115dd4):Draft — part of the autonomous night maintainer loop; complements AMB-58.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.