fix(cli): stop forwarding --no-open to agent-relay cloud login - #400
fix(cli): stop forwarding --no-open to agent-relay cloud login#400khaliqgant wants to merge 1 commit into
Conversation
relayfile login --no-open shelled out to agent-relay cloud login --no-open, but agent-relay does not support that flag, so headless login failed outright: "error: unknown option '--no-open'" then "error: agent-relay cloud login failed: exit status 1". agent-relay already prints the sign-in URL itself when it cannot open a browser, so relayfile's --no-open flag is kept for backward-compatible acceptance but is no longer forwarded. Fixes #378. Verified: - go build ./... - go test ./cmd/relayfile-cli/... -run TestLoginDelegatesToAgentRelay -v -count=1 - go test ./cmd/relayfile-cli/... -count=1 (full package suite, including the sibling TestLoginCanProvisionSeparateWorkspaceForMessagingOnlyRelaycastWorkspace test whose fake agent-relay handler also needed updating for the new non-forwarded invocation)
Relayfile Eval ReviewRun: Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0 Human Review CasesNo reviewable human-review cases captured Relayfile output. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #378.
`relayfile login --no-open` shelled out to `agent-relay cloud login --no-open`, but `agent-relay` does not support that flag, so headless login failed outright: `error: unknown option '--no-open'` then `error: agent-relay cloud login failed: exit status 1`. `agent-relay` already prints the sign-in URL itself when it cannot open a browser, so relayfile's `--no-open` flag is kept for backward-compatible acceptance but is no longer forwarded.
Root cause was independently reproduced live earlier this session before this fix was written.
Test plan