Skip to content

fix(cli): stop forwarding --no-open to agent-relay cloud login - #400

Draft
khaliqgant wants to merge 1 commit into
mainfrom
fix/378-no-open-not-forwarded
Draft

fix(cli): stop forwarding --no-open to agent-relay cloud login#400
khaliqgant wants to merge 1 commit into
mainfrom
fix/378-no-open-not-forwarded

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fixes #378.

`relayfile login --no-open` shelled out to `agent-relay cloud login --no-open`, but `agent-relay` does not support that flag, so headless login failed outright: `error: unknown option '--no-open'` then `error: agent-relay cloud login failed: exit status 1`. `agent-relay` already prints the sign-in URL itself when it cannot open a browser, so relayfile's `--no-open` flag is kept for backward-compatible acceptance but is no longer forwarded.

Root cause was independently reproduced live earlier this session before this fix was written.

Test plan

  • `go build ./...`
  • `go test ./cmd/relayfile-cli/... -run TestLoginDelegatesToAgentRelay -v -count=1`
  • `go test ./cmd/relayfile-cli/... -count=1` (full package suite)

Review in cubic

relayfile login --no-open shelled out to agent-relay cloud login
--no-open, but agent-relay does not support that flag, so headless
login failed outright: "error: unknown option '--no-open'" then
"error: agent-relay cloud login failed: exit status 1". agent-relay
already prints the sign-in URL itself when it cannot open a browser,
so relayfile's --no-open flag is kept for backward-compatible
acceptance but is no longer forwarded.

Fixes #378.

Verified:
- go build ./...
- go test ./cmd/relayfile-cli/... -run TestLoginDelegatesToAgentRelay -v -count=1
- go test ./cmd/relayfile-cli/... -count=1 (full package suite, including
  the sibling TestLoginCanProvisionSeparateWorkspaceForMessagingOnlyRelaycastWorkspace
  test whose fake agent-relay handler also needed updating for the new
  non-forwarded invocation)
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-08-05T12-04-31-964Z-HEAD-provider
Mode: provider
Git SHA: 71b5e41

Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0

Human Review Cases

No reviewable human-review cases captured Relayfile output.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2a874ac-3c2c-4e2c-961f-172624fcc8ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

login --no-open forwards a flag agent-relay doesn't have — headless login is impossible

1 participant