Skip to content

test(mountsync): cover write-only to mirror mode-flip backfill - #396

Draft
khaliqgant wants to merge 1 commit into
mainfrom
fix/262-write-only-mirror-backfill-test
Draft

test(mountsync): cover write-only to mirror mode-flip backfill#396
khaliqgant wants to merge 1 commit into
mainfrom
fix/262-write-only-mirror-backfill-test

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 4, 2026

Copy link
Copy Markdown
Member

Closes #262.

Adds the missing regression for a write-only mount later flipped to mirror mode: performs a real write-only cycle, recreates the syncer in mirror mode against the same state dir, and proves pre-existing remote history is tree-listed/read/materialized instead of being skipped by the restart fast-path.

Test-only PR, no production code change. The underlying runtime fix (persist SyncMode and reset BootstrapComplete/bootstrap checkpoints in loadState on write-only→mirror transition) already exists on main — independently verified this test passes cleanly against a fresh origin/main checkout with no other changes, before opening this PR.

Test plan

  • go test ./internal/mountsync/... -run TestSyncOnceWriteOnlyToMirrorBackfillsExistingRemoteFiles -v -count=1
  • go test ./internal/mountsync/... -count=1

Review in cubic

Adds the missing regression for a write-only mount later flipped to
mirror mode: performs a real write-only cycle, recreates the syncer in
mirror mode against the same state dir, and proves pre-existing remote
history is tree-listed/read/materialized instead of being skipped by
the restart fast-path.

The underlying runtime fix (persist SyncMode and reset
BootstrapComplete/bootstrap checkpoints in loadState on write-only to
mirror transition) already exists on main — verified this test passes
against a clean origin/main checkout with no production code changes.

Closes #262.

Verified independently:
- go test ./internal/mountsync/... -run TestSyncOnceWriteOnlyToMirrorBackfillsExistingRemoteFiles -v -count=1
- go test ./internal/mountsync/... -count=1
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd712ef7-717a-4802-bbe2-e64c19ec7698

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-08-04T17-56-51-326Z-HEAD-provider
Mode: provider
Git SHA: 99696c2

Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0

Human Review Cases

No reviewable human-review cases captured Relayfile output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

write-only mounts set BootstrapComplete=true without mirroring → write-only→mirror flip silently skips backfill

1 participant