feat(discovery): register reddit + granola writeback discovery - #164
Conversation
Reddit and granola declare writeable resources in resources.ts and their LAYOUT.md prompts advertise discovery schemas, but the discovery/ assets were never authored and neither adapter was registered in scripts/writeback-discovery-data.mjs, so verify-writeback-discovery.mjs never covered them and published packages shipped no schema files. - register reddit (track subreddit, create post) and granola (create note, create folder) in writeback-discovery-data.mjs; post fields mirror the reddit-composio-relay create-post action input, note and folder fields mirror the adapter record types - add reddit/granola id-pattern cases to the discovery normalizer so generated .adapter.md ID patterns match the runtime idPattern regexes in each adapter's resources.ts - generate discovery/<provider>/.adapter.md, .schema.json, and .create.example.json for both adapters - ship discovery/ in @relayfile/adapter-reddit package files Fathom is intentionally unregistered: its resources.ts exports an empty resource list and /fathom/LAYOUT.md documents the mount as read-only with no file-native writeback contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 18 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The merge-order note refers to #165 — both PRs touch |
|
Reviewed PR #164 and made one scoped fix: Reddit post writeback discovery no longer uses the reserved system Fixed in:
Addressed comments
Advisory NotesNone. VerificationPassed locally:
Note: the default concurrent |
|
Reviewed PR #164 and fixed one demonstrated gap: I also validated the PR’s generated discovery assets, Reddit package publishing metadata, and generator declarations. I reverted broad generator fallout from an exploratory regeneration because it touched unrelated adapter resources and broke Linear tests. Addressed comments
Verification
I used low Turbo concurrency because the default parallel build was killed with exit 137 in this sandbox. |
Summary
reddit and granola had writeable resources in
resources.tsbut no discovery registration — they couldn't pass writeback discovery verification, and reddit's published package wouldn't have shipped discovery files at all.subreddits,subreddits/{subreddit}/posts) and granola (notes,folders) inscripts/writeback-discovery-data.mjs; field definitions derive from the actual zod inputs / record types (reddit post fields mirror cloud'screate-post.tsaction), nothing invented.idPatternForcases in the normalizer so generated docs match each adapter's runtimeidPatternregexes..adapter.md+.schema.json+.create.example.jsonfor all four endpoints.packages/reddit/package.json:filesnow includes"discovery".fathom intentionally excluded: it's read-only by design (empty resources export with an explicit comment, LAYOUT.md states no writeback schemas, listed in
adapters-without-writeback-paths.generated.json). Registering it would fail verification and contradict the design.Note: the discovery generator's renderer is stale vs. several hand-tuned
resources.tsfiles (dropbox/hubspot/linear drift); hand-maintainedresources.tsfiles were restored after generation — only discovery assets kept.Verification
test:writeback-discoverypasses ("Verified 86 writeback discovery endpoints", was 82); turbo build/test/typecheck for reddit/granola/fathom/core green; catalog check in sync; publish-targets / internal-dependencies / digest-contracts checks pass.scripts/writeback-discovery-data.mjs— merge one, regenerate, then merge the other.🤖 Generated with Claude Code