docs: correct the audit header to the database production actually uses - #304
docs: correct the audit header to the database production actually uses#304khaliqgant wants to merge 1 commit into
Conversation
The header recorded figures from the first run of this script, which went against the pre-cutover `relaycast` instance rather than `relaycast-cloud`, the one the worker binds. The deployment figures reported to the design partner and in the migration record are 4 colliding pair groups, 87 mismatched ids and 2607 two-party conversations; the header said 30 and 3425. The finding replicated on both instances so the conclusion held, but the numbers in the script disagreed with every other record of the same run. Also names which instance the figures come from and how to resolve it (the SST resource, never the name matching the repo), and adds the missing `--remote` to the usage example — without it wrangler reads the local emulated database and the audit reports on nothing. Comment-only; no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe audit script updates production mismatch and conversation counts. It explains the database-instance correction and identifies the hosted database. It also documents the ChangesAudit documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
scripts/audit-dm-reservations.mjsParsing error: /scripts/audit-dm-reservations.mjs was not found by the project service. Consider either including it in the tsconfig.json or including it in allowDefaultProject. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
What
Comment-only correction to
scripts/audit-dm-reservations.mjs. No behaviour change.The header recorded 30 mismatched ids and 3425 two-party conversations. Those figures come from the first run of this script, which went against the pre-cutover
relaycastD1 instance rather thanrelaycast-cloud— the one the worker actually binds. Every other record of that run (the migration record, and what was reported to the Ratify design partner) says 4 colliding pair groups, 87 mismatched ids, 2607 two-party conversations.The finding replicated on both instances, so the conclusion held and the deployment was correct. But the script disagreed with itself and with everything else describing the same run, and it is the artifact someone would read first.
Also
RelaycastDatabase, never by the name matching this repo. Two live instances carry DM data under confusingly close names, which is how the wrong one got audited in the first place.--remoteto the usage example. Without itwrangler d1 executereads the local emulated database, so the audit silently reports on nothing — hit while re-running this against production today.Verification
Re-ran the script against
relaycast-cloudtoday: 3078 1:1 conversations scanned, 2961 reservable, 117 skipped (101 orphaned two-party, 16 self-DM), and zero findings in all three checks. Reservation table: 0 colliding pair groups, 0 reservations without a conversation, 0 unsorted pairs, and 0 of the 2961 two-party conversations without a reservation.🤖 Generated with Claude Code