Skip to content

Fix #521: enforce Node SDK napi conformance in CI - #533

Open
willwashburn wants to merge 2 commits into
mainfrom
issue-521-napi-ci-conformance
Open

Fix #521: enforce Node SDK napi conformance in CI#533
willwashburn wants to merge 2 commits into
mainfrom
issue-521-napi-ci-conformance

Conversation

@willwashburn

@willwashburn willwashburn commented Aug 3, 2026

Copy link
Copy Markdown
Member

Fixes #521

The always-on Node CI job now builds a native napi binding before running the full npm test suite. The gated test step uses isolated HOME and RELAYBURN_HOME paths, and CI fails when the binding gate, native artifact, or esbuild prerequisite is missing.

The Node SDK conformance helper also verifies that the loaded .node comes from the current checkout instead of an installed platform package. The local loader now resolves the actual src/index.<target>.node build output first.

The publish workflow reuses its existing napi matrix artifacts for its gated test run, and missing artifacts fail immediately. Local fresh-checkout behavior remains opt-in and may skip native tests until pnpm run build:napi is run.

Validation:

  • pnpm install --frozen-lockfile && pnpm run build:napi && RELAYBURN_SDK_NAPI_BUILT=1 pnpm run test (SDK 11 passed, 0 skipped; MCP 21 passed, 0 skipped)
  • CI-equivalent debug napi build and isolated gated root test (same 0-skip result)
  • Negative CI tests for an absent gate, missing local binding, and missing esbuild
  • cargo test --workspace
  • actionlint and YAML parsing for all edited workflows

🤖 Generated with Claude Code

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@willwashburn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b41b0c35-5040-4613-ae7f-c237a924083e

📥 Commits

Reviewing files that changed from the base of the PR and between 5b531d0 and df1b550.

📒 Files selected for processing (9)
  • .github/workflows/ci.yml
  • .github/workflows/napi-build.yml
  • .github/workflows/publish.yml
  • packages/sdk-node/CHANGELOG.md
  • packages/sdk-node/src/binding.cjs
  • packages/sdk-node/test/conformance.test.js
  • packages/sdk-node/test/esbuild-smoke.test.js
  • packages/sdk-node/test/helpers/napi.js
  • packages/sdk-node/test/no-onlog.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: run Node SDK conformance tests with the napi binding

1 participant