Fix #525: enforce golden suite in CI and publish - #532
Conversation
|
Warning Review limit reached
Next review available in: 38 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Important
Merge order: #527 must merge first. Then update this branch from
main, confirm CI is green, and only then merge this PR. Until #527 lands, this PR's golden gate intentionally exposes four pre-existing failures onmain(summary,summary-json,state-status, andstate-status-json); this PR does not cause those output drifts.Fixes #525
The existing CLI golden test returns early unless
BURN_GOLDEN=1, but neither workflow that runscargo test --workspacesupplied that variable. As a result, CI and the release gate reported success without checking committed CLI output snapshots.This change sets
BURN_GOLDEN=1at step scope for the Rust test steps in both CI and the publish workflow. It also updates the golden harness documentation to describe the enforced workflow behavior and the opt-in local default. Snapshot data, assertions, and per-invocation enablement remain unchanged.Validation:
cargo test --workspacecargo fmt --all -- --checkactionlint .github/workflows/ci.ymlactionlint -ignore 'SC2086' .github/workflows/publish.yml(the ignored finding at line 1062 predates this change)BURN_GOLDEN=1 cargo test --workspacetwice on Fix #524: prevent retired models from inheriting reseller pricing #527 head, including a passing 5/5 golden target🤖 Generated with Claude Code