Skip to content

Fix #525: enforce golden suite in CI and publish - #532

Open
willwashburn wants to merge 1 commit into
mainfrom
issue-525-golden-in-ci
Open

Fix #525: enforce golden suite in CI and publish#532
willwashburn wants to merge 1 commit into
mainfrom
issue-525-golden-in-ci

Conversation

@willwashburn

@willwashburn willwashburn commented Aug 3, 2026

Copy link
Copy Markdown
Member

Important

Merge order: #527 must merge first. Then update this branch from main, confirm CI is green, and only then merge this PR. Until #527 lands, this PR's golden gate intentionally exposes four pre-existing failures on main (summary, summary-json, state-status, and state-status-json); this PR does not cause those output drifts.

Fixes #525

The existing CLI golden test returns early unless BURN_GOLDEN=1, but neither workflow that runs cargo test --workspace supplied that variable. As a result, CI and the release gate reported success without checking committed CLI output snapshots.

This change sets BURN_GOLDEN=1 at step scope for the Rust test steps in both CI and the publish workflow. It also updates the golden harness documentation to describe the enforced workflow behavior and the opt-in local default. Snapshot data, assertions, and per-invocation enablement remain unchanged.

Validation:

  • cargo test --workspace
  • cargo fmt --all -- --check
  • actionlint .github/workflows/ci.yml
  • actionlint -ignore 'SC2086' .github/workflows/publish.yml (the ignored finding at line 1062 predates this change)
  • BURN_GOLDEN=1 cargo test --workspace twice on Fix #524: prevent retired models from inheriting reseller pricing #527 head, including a passing 5/5 golden target
  • YAML parsing for both edited workflows

🤖 Generated with Claude Code

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@willwashburn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 86ae6a84-3697-4466-a6e1-aa97059939b2

📥 Commits

Reviewing files that changed from the base of the PR and between 5b531d0 and ce3b14c.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/publish.yml
  • crates/relayburn-cli/tests/golden.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: gated golden suite never runs — BURN_GOLDEN unset in every workflow

1 participant