-
Notifications
You must be signed in to change notification settings - Fork 14
Add Trustabl Agent Scanner to CI #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kathrina-trustabl
wants to merge
1
commit into
AgentToolkit:main
Choose a base branch
from
kathrina-trustabl:add-trustabl-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Trustabl Agent Scanner | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| # Minimal top-level permissions; write grants are scoped to the scan job only. | ||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| scan: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| concurrency: | ||
| group: trustabl-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| pull-requests: write | ||
| # continue-on-error keeps this job advisory — findings are reported but | ||
| # CI does not go red so unrelated work is never blocked. | ||
| continue-on-error: true | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: trustabl/trustabl-action@973f666d20b5fbb2e6a4511bd3846e965a08c28b # v0.4.1 | ||
| with: | ||
| version: v0.1.6 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: AgentToolkit/altk-evolve
Length of output: 473
🏁 Script executed:
Repository: AgentToolkit/altk-evolve
Length of output: 50382
🏁 Script executed:
Repository: AgentToolkit/altk-evolve
Length of output: 10111
🏁 Script executed:
Repository: AgentToolkit/altk-evolve
Length of output: 12100
🌐 Web query:
GitHub Actions expressions property dereference output name hyphen steps.outputs.exit-code continue-on-error outcome💡 Result:
In GitHub Actions, using dot notation (e.g., steps.my-step.outputs.my-output) for step IDs or output names that contain hyphens will cause expression evaluation failures [1]. This occurs because the expression evaluator interprets the hyphen as a subtraction operator rather than part of the identifier [2][1]. To resolve this, you must use bracket notation (index syntax) to reference the property [2][1]. For example, if you have a step with an ID of my-step and an output named exit-code, you should access it as follows: ${{ steps['my-step'].outputs['exit-code'] }} This ensures the string is treated as a literal key rather than a mathematical operation [3]. Regarding continue-on-error and outcome: The steps context provides both an outcome and a conclusion for each step [4][5]. - steps.<step_id>.outcome: Contains the result of the step before the continue-on-error setting is applied (e.g., success, failure, cancelled, or skipped) [4][5]. - steps.<step_id>.conclusion: Contains the final result of the step after the continue-on-error setting is applied [4][5]. If a step has continue-on-error: true and it fails, the outcome will be failure, but the conclusion will be success [4][5].
Citations:
Fail on scanner errors while keeping findings advisory.
Job-level
continue-on-errorhides Trustabl exit code2and other action failures. Move it to the Trustabl step and add a follow-up check. Usesteps.trustabl.outputs['exit-code']becauseexit-coderequires bracket notation. Allow exit code1, but fail for exit code2, missing output, or other failures.🤖 Prompt for AI Agents