Repository navigation
Go GenAI submodules: require published agenttel-go, make them installable - #30
Merged
Merged
Conversation
genai/openai and genai/anthropic pinned agenttel-go v0.1.0 (never published) and relied on a replace directive, which consumers ignore, so neither module could be installed. - require go.agenttel.dev/agenttel-go v0.4.0-alpha, drop the replace - agenttel-go/go.work links them to the checkout for local development - CI also builds and tests them with GOWORK=off, as consumers do - compile-checked ExampleWrap for both (shown on pkg.go.dev) - quick-start: install commands and correct GenAI usage (EndSpanSuccess takes a ChatResult) Signed-off-by: Rohit Kumar <rrohit.ramsen@gmail.com>
Signed-off-by: Rohit Kumar <rrohit.ramsen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Go GenAI submodules installable so they can be released as
v0.4.0-alpha.Problem:
go.agenttel.dev/agenttel-go/genai/openaiand.../genai/anthropicrequiredagenttel-go v0.1.0, which was never published, and worked only throughreplace ../../. Go ignoresreplacein dependencies, so nobody couldgo getthem.Changes
go.modfiles now require the publishedgo.agenttel.dev/agenttel-go v0.4.0-alpha, and thereplaceis removed.agenttel-go/go.worklinks the submodules to this checkout for local development and CI.GOWORK=off, exactly as consumers get them.ExampleWrapfor both packages. They're compile-checked, so they can't drift, and pkg.go.dev shows them.EndSpanSuccesstakes agenai.ChatResult, not three values.Tested (Docker, Go 1.24)
GOWORK=off, each submodule resolvesagenttel-go v0.4.0-alphafrom the Go proxy, and vet and tests pass.actionlintpasses onci.yml.After merge (not done in this PR)
Tag the merge commit and push the tags:
agenttel-go/genai/openai/v0.4.0-alphaagenttel-go/genai/anthropic/v0.4.0-alpha