fix: avoid redacting structured numeric values as phones - #113
Merged
royalpinto007 merged 3 commits intoSep 8, 2026
Conversation
vsolano9
force-pushed
the
fix/redact-phone-nondates
branch
from
September 8, 2026 13:38
37f9c2c to
64a4bc6
Compare
|
Merged, @vsolano9. Thank you for taking the time. Genuinely helpful change for agentpostmortem. If this project helps you out, a star helps others find it too. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
redactPhonesnow requires a recognizable phone-number structure before redacting, so ISO 8601 dates, timestamps, versions, identifiers, and other structured numeric values remain intact. All-zero placeholders are also left unchanged.Updated the PII regression coverage for the reported false-positive shapes while preserving common phone-number redaction.