fix: scan dist/ and build/ for bundled executable artefacts - #37
Open
sharadvc wants to merge 1 commit into
Open
Conversation
1 task
Member
|
Good instinct, but removing dist/build from the default skip would double-report every finding (source + bundle) for most skills. Please gate this behind an opt-in flag instead, e.g. --include-build, keeping the default as-is. Happy to merge once it's opt-in. |
Skills may ship bundled scripts under dist/ or build/ that agents execute directly. Stop skipping those directories while still ignoring .git, node_modules, .venv, venv, and __pycache__. Fixes AgentPostmortem#6
cursor
Bot
force-pushed
the
cursor/scan-dist-build-4807
branch
from
September 12, 2026 13:26
7385452 to
8ae4b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/andbuild/were inSKIP_DIR, so bundled scripts agents actually run (e.g.dist/setup.js) were never audited. They are no longer skipped;.git,node_modules,.venv, and__pycache__remain skipped.Test plan
npm test— includes coverage thatdist//build/scripts are collected and rules can fire thereFixes #6