Fix directory scanning of batch, fish, and PowerShell module scripts - #18
Merged
royalpinto007 merged 1 commit intoSep 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix directory scanning of batch, fish, and PowerShell module scripts
What does this PR do?
Fixes #15. Directory scans now include
.bat,.cmd,.fish, and.psm1files through the existing extension filter. Previously these files were silently omitted.Adds a regression covering all four extensions at the root and in a nested directory, in lowercase and uppercase, with existing supported files and unrelated
.binfiles as controls. It also checks that the newly collected scripts produce findings. Bumps the patch version to 0.1.4 and documents the fix in the changelog.Checklist
node --test)CHANGELOG.mdentryNotes
Prepared with OpenAI Codex assistance, including implementation, regression tests, and this draft.
Validation on macOS (final revision: Node v20.19.5 and v18.18.0):
node --teston Node 20 and Node 18. The earlier revision also passednpm teston Node 24.--fail-on high, for text, JSON, and SARIF output. JSON and SARIF parsed successfully; findings matched clean/flagged expectations.git diff --checkpassed.Fixture scripts were read as scanner input, never executed. Node 20 checks ran locally on macOS; GitHub-hosted Linux CI has not run.