Skip to content

decide() auto-approves zero/negative refund amounts #3

Description

@royalpinto007

Problem

decide() returns "auto_approve" for 0.0 and -20.0 amounts, issuing $0/negative refunds. There is no non-positive check before the limit comparison.

Where

relayg/policy.py (if amount < AUTO_APPROVE_LIMIT, amount unchecked).

Acceptance

Add a failing test first with refund 0.0 and -20.0, expecting anything but "auto_approve". Then fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions