fix: reject malformed --header values instead of dropping them - #44
Merged
royalpinto007 merged 1 commit intoSep 12, 2026
Merged
Conversation
Throw when a --header argument has no colon or an empty name, so audits cannot run unauthenticated due to a mistyped header. Fixes AgentPostmortem#24
|
And it's in. Thanks @sharadvc. Contributions like this are what keep MCP-audit moving. A star on the repo would mean a lot if this project is useful to you. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Malformed
--headervalues (no colon, or empty name before:) now fail with a clear error and exit code 2 instead of being silently dropped.Test plan
npm test— includes reject header without colonFixes #24