fix: reject static manifests with non-array tools - #43
Closed
sharadvc wants to merge 1 commit into
Closed
Conversation
Validate tools during manifest normalization so invalid values like strings fail fast instead of being iterated as characters. Fixes AgentPostmortem#25 Co-authored-by: Sharad. <sharadvc@users.noreply.github.com>
Member
|
Thanks! Merging #39 for this one since it covers more shapes (string/object/number/boolean) and preserves null/empty correctly. Appreciate the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
toolsis present but not an array (e.g. a string),normalize()now fails fast withInvalid manifest …: tools must be an arrayinstead of iterating characters.Test plan
npm test— includes reject non-array tools caseFixes #25