Skip to content

fix: empty contains needle should fail, not always pass #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royalpinto007 merged 1 commit into from
Sep 12, 2026
Merged

fix: empty contains needle should fail, not always pass #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scorers/contains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function asList(value: unknown): string[] {
export const containsScorer: Scorer = {
type: "contains",
score(spec: ScorerSpec, ctx: ScoreContext) {
const needles = [...asList(spec.value), ...asList(spec.values)];
const needles = [...asList(spec.value), ...asList(spec.values)].filter((n) => n.length > 0);
if (needles.length === 0) {
return result(spec, { score: 0, passed: false, reason: "no value(s) provided" });
}
Expand All @@ -44,7 +44,7 @@ export const containsScorer: Scorer = {
export const notContainsScorer: Scorer = {
type: "not-contains",
score(spec: ScorerSpec, ctx: ScoreContext) {
const needles = [...asList(spec.value), ...asList(spec.values)];
const needles = [...asList(spec.value), ...asList(spec.values)].filter((n) => n.length > 0);
if (needles.length === 0) {
return result(spec, { score: 0, passed: false, reason: "no value(s) provided" });
}
Expand Down
4 changes: 4 additions & 0 deletions tests/scorers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ describe("regex", () => {
});

describe("contains / not-contains", () => {
it("fails when needle is an empty string", async () => {
const r = await run(containsScorer, { type: "contains", value: "" }, ctx("anything"));
expect(r.passed).toBe(false);
});
it("gives partial credit when some substrings missing", async () => {
const r = await run(containsScorer, { type: "contains", values: ["a", "b", "c"] }, ctx("a and b"));
expect(r.passed).toBe(false);
Expand Down
Loading