Fix empty filtered runs passing - #32
Merged
Merged
Conversation
|
Nice work @vsolano9, this is merged. Contributions like this are what keep Evalgate moving. A star on the repo would mean a lot if this project is useful to you. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- fail runs when tag filtering selects zero cases, even without a threshold\n- explain empty filtered runs in the terminal report\n- add regression coverage for both behaviors\n\nFixes #6\n\n## Verification\n\n-
RUN v1.6.1 /private/tmp/evalgate-oss-next
✓ tests/runner.test.ts (10 tests) 3ms
✓ tests/reporters.test.ts (7 tests) 2ms
Test Files 2 passed (2)
Tests 17 passed (17)
Start at 16:08:00
Duration 202ms (transform 63ms, setup 0ms, collect 117ms, tests 5ms, environment 0ms, prepare 79ms) (17 passed)\n- regression test observed failing before the runner change and passing after it