fix: report ignore-file write errors cleanly - #47
Merged
royalpinto007 merged 2 commits intoSep 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I catch failures from ignore-file writes so the CLI prints its usual concise error and returns 2. This also avoids a misleading success report when the second target fails; earlier successful writes remain in place.
Closes #44.
Checklist
node --test)CHANGELOG.mdentryNotes
31 tests pass with Node 20.20.0, plus the fixture CLI JSON smoke. The four new cases first reproduced uncaught EACCES on unchanged main, covering text/JSON output and first/second-target failure.
I bumped the patch version as required and removed the existing conflict markers from
package-lock.jsonwhile synchronizing its version. No runtime dependencies were added.Prepared with assistance from Codex.