Skip to content

Fix top zero report handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royalpinto007 merged 1 commit into from
Sep 8, 2026
Merged

Fix top zero report handling #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ export function textReport(scan, { price, top, wrote }) {
const cats = Object.entries(t.byCategory).sort((a, b) => b[1].tokens - a[1].tokens);
L.push(c("90", " by category: ") + cats.map(([k, v]) => `${k} ${fmtTokens(v.tokens)}`).join(c("90", " · ")));
L.push("");
L.push(c("1", " Top offenders"));
for (const f of scan.files.filter((f) => f.trim).slice(0, top)) {
const tok = ("~" + fmtTokens(f.tokens)).padStart(7);
L.push(` ${c("33", tok)} ${c("90", usd(dollars(f.tokens, price)).padStart(7))} ${f.rel} ${c("90", "— " + f.reason)}`);
if (top > 0) {
L.push(c("1", " Top offenders"));
for (const f of scan.files.filter((f) => f.trim).slice(0, top)) {
const tok = ("~" + fmtTokens(f.tokens)).padStart(7);
L.push(` ${c("33", tok)} ${c("90", usd(dollars(f.tokens, price)).padStart(7))} ${f.rel} ${c("90", "— " + f.reason)}`);
}
}
L.push("");
if (wrote && wrote.length) {
Expand All @@ -57,4 +59,4 @@ export function jsonReport(scan, { price, wrote }) {
offenders: scan.files.filter((f) => f.trim).map((f) => ({ path: f.rel, tokens: f.tokens, category: f.category, reason: f.reason })),
wrote: wrote || [],
}, null, 2);
}
}
9 changes: 9 additions & 0 deletions test/ctxtrim.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { dirname, join } from "node:path";
import { scanRepo, estimateTokens } from "../src/scan.js";
import { classify, classifyPath } from "../src/classify.js";
import { merge, block } from "../src/ignore.js";
import { textReport } from "../src/report.js";

const repo = join(dirname(fileURLToPath(import.meta.url)), "fixtures", "sample-repo");
const cli = join(dirname(fileURLToPath(import.meta.url)), "..", "bin", "ctxtrim.js");
Expand Down Expand Up @@ -185,3 +186,11 @@ test("unknown --targets values fail before writing ignore files", (t) => {
assert.equal(existsSync(join(root, ".aiexclude")), false);
assert.equal(existsSync(join(root, ".aiignore")), false);
});
test("textReport with top: 0 omits Top offenders header", () => {
const scan = scanRepo(repo);
const out = textReport(scan, { price: 3, top: 0 });
assert.ok(
!out.includes("Top offenders"),
"should not show Top offenders header when top is 0",
);
});
Loading