fix: reject invalid numeric CLI options - #13
Merged
royalpinto007 merged 2 commits intoSep 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate numeric CLI options before scanning a repository so invalid thresholds cannot produce misleading reports or silently disable a CI gate.
Background
Number()converted values such asabctoNaN, while negative values were accepted. That allowed--max-tokens abc,--price -3, and--top -1to exit successfully with nonsensical behavior.Changes
--priceand--max-tokens.--topto be a non-negative integer.--fail-on-wasteto be a finite percentage from 0 through 100.--option=valueforms.Implementation
Validation runs before repository scanning and ignore-file writes, so invalid input exits with status 2 without filesystem side effects. Existing defaults and valid scan/report behavior are unchanged.
Compatibility / Known limitations
The project remains zero-dependency and supports its existing Node.js >=18 engine range. The local environment used Node 22; the repository workflow runs the same tests on Node 20.
Tests
npm test— 9 passed, 0 failed.node bin/ctxtrim.js test/fixtures/sample-repo --format json— smoke output generated successfully.node --check src/cli.jsnode --check bin/ctxtrim.jsgit diff --checkIssue
Closes #8