Skip to content

shopify_tag_order forwards NaN/negative orderId and empty tags to Shopify #8

Description

@royalpinto007

Problem

shopify_tag_order forwards NaN/negative orderId and empty tags to Shopify: Number("abc") is interpolated into the order URL with no check.

Where

src/tools.ts (Number(args.orderId), String(args.tags ?? "")) + connectors.ts URL interpolation.

Acceptance

Add a failing test first calling the tool with {orderId: "abc", tags: ""}, expecting a validation error and zero fetch calls. Then fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions