Skip to content

fix: hint when --dir points to a file #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royalpinto007 merged 2 commits into from
Sep 9, 2026
Merged

fix: hint when --dir points to a file #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf2006a
fix: hint when --dir points to a file
garvg8130-ux Sep 8, 2026
5f907fe
resolve merge: keep --dir hint test alongside main's test suite
royalpinto007 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion agentrace/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,17 @@ def _load(args) -> list[AgentRun]:
if args.file:
sessions = [parse_session(Path(args.file))]
else:
sessions = parse_all(Path(args.dir) if args.dir else None)
path = Path(args.dir) if args.dir else None

if path and path.is_file():
console.print(
f"[yellow]Hint:[/] {escape(str(path))} is a file. "
"Use [bold]--file[/] instead of [bold]--dir[/]."
)
return []

sessions = parse_all(path)

runs = [r for s in sessions for r in s.runs]
if not runs:
source = args.file or args.dir or "~/.claude/projects"
Expand Down
9 changes: 8 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,14 @@ def test_empty_result_names_selected_directory(tmp_path):
assert "No subagent runs found." in result.stdout
assert f"Looked in {tmp_path}." in result.stdout

def test_dir_given_file_hints_to_use_file(tmp_path):
transcript = tmp_path / "session.jsonl"
transcript.write_text("")
result = run_cli("--dir", str(transcript), "list")
assert "--file" in result.stdout


def test_version():
result = run_cli("--version")
assert result.returncode == 0
assert "0.1.0" in result.stdout
assert "0.1.0" in result.stdout
Loading