Fix mixed timestamp timezone parsing - #35
Merged
royalpinto007 merged 1 commit intoSep 8, 2026
Merged
Conversation
|
Merged. Thanks a lot, @Gambit-Checkmate. Agentrace gets better every time someone outside the repo digs in like this. If you find Agentrace useful, consider dropping a star. It helps more people find it. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A transcript mixing offset-aware and offset-naive timestamps crashes when its runs are sorted. Parse timestamps without offsets as UTC, while preserving explicit offsets, so sorting and duration subtraction use comparable datetimes independently of the local timezone. Make the missing-timestamp sort fallback UTC-aware as well.
Closes #27. Also addresses the missing-timestamp sorting crash described in #3.
Changes
TypeErrorbefore the fix; the explicit-offset case already passed.Validation
All 33 tests pass. Both modified Python files pass the format check; the new test file passes Ruff. Ruff on
parse.pyretains two pre-existing diagnostics (UP035andFURB162), verified againstorigin/main; the previousDTZ901diagnostic is resolved.git diff --checkpasses.Checklist