feat(memory): add global and session memory search - #665
Open
xiami762 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_searchtool.Key Changes
memory.search.embedding.enabledconfiguration, defaulting tofalse, and write the minimal Memory Search configuration on first run.Impact Scope
memory_searchto retrieve durable Memory and, when requested, Session history with file/line citations.memory.search.embeddingsettings. Embeddings are disabled by default and require no new secret unless enabled.Business Logic to Review
MemoryManagerreconciliation and the boundary between Global Memory, Project Memory, Daily Memory, and Session history.MemoryIndexerfile discovery, project scoping, stale-file cleanup, and idempotent incremental updates.Why This Approach
memory_searchinterface instead of introducing a separate Memory CRUD tool.Test Plan
uv run pytest tests/memory/test_memory_scope.py tests/memory/test_session_transcript_search.py tests/config/test_config_init.py tests/storage/test_storage.py tests/session/test_message_parts_persistence.py -q(94 passed)Compatibility, Migration & Rollback