Repository navigation
Job harness: valves that lag because the module missed frames are the runner's, not the app's - #835
Merged
Merged
Conversation
… runner's, not the app's The 2026-11-14 nightly reported VALVES-NOT-FOLLOWING in J19 (1.1 s against a 1 s limit) on a rig runner whose emulated module received 0.6-4.5 % fewer PGN 239/229 frames than the night before in 12 jobs, while the other job harnesses on the same build received every frame. The module hears the app over real UDP on its own thread while the run goes faster than the clock. Each fix now gives its frames up to 5 ms to arrive, and ValveFollowTally counts the frames the module never got while online; a mismatch stretch in which frames were lost is counted apart and reported as a harness note with the count. A module that is off or offline loses frames on purpose and still counts against the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-11-14 nightly reported
VALVES-NOT-FOLLOWINGin J19 (1.1 s against the 1 s limit). That night the rig runner's emulated machine module received 0.6–4.5 % fewer PGN 239/229 frames than the night before in 12 jobs, J19 among them (606,522 of 635,300). The other job harnesses on the same build received every frame. The module hears the app over real UDP on its own thread, while the run goes faster than the clock.Change
JobRun.WaitForFrames).ValveFollowTallycounts the PGN 239 frames the module never got while online.Tests
ValveFollowTallyTests(5, run without a rig, in milliseconds).VALVES-NOT-FOLLOWINGas expected.🤖 Generated with Claude Code