Skip to content

chore: add dockerfile for api#124

Open
kvcpr wants to merge 2 commits into
AfterShip:mainfrom
hypedevs:chore/add-dockerfile
Open

chore: add dockerfile for api#124
kvcpr wants to merge 2 commits into
AfterShip:mainfrom
hypedevs:chore/add-dockerfile

Conversation

@kvcpr
Copy link
Copy Markdown

@kvcpr kvcpr commented Jul 18, 2024

  • Added dockerfile for api server
  • Added correct response header for success response

Copy link
Copy Markdown
Contributor

@lryong lryong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lryong lryong requested review from NeoCN and git-hulk September 10, 2024 12:32
Comment thread Dockerfile
@@ -0,0 +1,12 @@
FROM --platform=linux/amd64 golang:1.22.5-alpine3.20
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to specify the platform in the Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants