Fix: Prevent geometric mean underflow for small values#362
Open
sunlight7777777 wants to merge 1 commit intoAffineFoundation:mainfrom
Open
Fix: Prevent geometric mean underflow for small values#362sunlight7777777 wants to merge 1 commit intoAffineFoundation:mainfrom
sunlight7777777 wants to merge 1 commit intoAffineFoundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of geometric_mean computes the product of all values before taking the nth root. For many small positive values (e.g. [1e-200] * 1000), this causes floating-point underflow to 0.0, producing incorrect results.
Root Cause
Iterative multiplication underflows in IEEE 754 double precision:
product *= v
Solution
Replaced the product-based computation with a numerically stable log-space formulation:
exp(sum(log(v)) / n)
This avoids underflow while preserving mathematical correctness.
Impact
Fixes incorrect outputs for small-value inputs
Improves numerical stability of scoring functions
No breaking changes
Example
Before:
geometric_mean([1e-200] * 1000) → 0.0
After:
→ ~1e-200