Repository navigation
Fix search keyboard routing and queued image capture for 2.8.7 - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History search intercepted Return and arrow keys even when a filter/button had focus, with VoiceOver modifiers, or during IME composition. Restrict shortcuts to the search field/results and leave native editing/navigation intact. Also recheck the image-history setting before queued screenshot writes and short-circuit body normalization when the title already matches.
Regressions reproduced before the fixes: 18 keyboard assertions failed, and a queued screenshot remained stored after image capture was disabled. Afterward, debug, strict Swift 6 release, ASan and TSan each pass 371 XCTest (8 opt-in skips) plus 4 Swift Testing checks. Site/SEO suites and publishable-tree/full-history secret scans pass.
Synthetic in-memory search, 64 × 512 KiB ASCII bodies, 30 warmed release iterations on the same host: p50 164.965 → 3.741 ms; p95 229.571 → 4.187 ms. This is database search, not end-to-end UI latency. Physical isolated UI smoke recovered after a relaunch: search filters/Return do not paste, query returns the expected fixture, Down changes selection, Ctrl+Option+Up leaves it unchanged. Default-size UI inspected; VoiceOver audio remains unverified. AppKit responder and marked-text integration tests pass. Stable release toolchain Swift 6.4.0.34.1 also passes the full strict suite.
Prepares 2.8.7/build 53. Public download metadata remains 2.8.6 until signed artifacts are published and independently downloaded. Full audit scope, evidence and deferred P2 findings: artifacts/neclip-audit-20260926/LOOP.md.