Install the npm latest dist-tag, and let the first publish come from main - #130
Merged
Merged
Conversation
…main Two things about this repository's release topology break the launcher as it was merged. The agent's maintenance releases are cut from branches that never reach main: v0.3.1 is on npm as `latest`, while main still declares 0.3.0. A launcher that installs its own version would therefore hand pip users an older agent than `npm install -g aether-agents@latest` hands npm users -- the exact opposite of what this package promises. So the default install target is now the `latest` dist-tag, and this package's version means only "the launcher released alongside main". `self install --npm-version` and AETHER_AGENT_NPM_VERSION still pin an exact one, and `self doctor` now prints what it would fetch, so the distinction is visible rather than implied. The publish workflow also could not run at all: it demanded a release tag, and no tag cut before this launcher existed contains packages/pypi-cli. A dispatch may now build main, which is how the first publish has to happen; a release still publishes from its own immutable tag, and the tag-equals-version check still applies whenever the ref is a tag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things about this repository's release topology break the launcher as merged in #129. Found while trying to run the first publish.
1. Pinning to this package's version installs the wrong agent
v0.3.1is on npm aslatest, cut from a branch that never reached main — main still declares0.3.0. A launcher that installs its own version would hand pip users agent0.3.0whilenpm install -g aether-agents@latesthands npm users0.3.1. That is the opposite of what the package promises.So the default install target is the
latestdist-tag. This package's version now means only "the launcher released alongside main". Pinning is still available and still validated:aether-agent self install --npm-version 0.3.1 AETHER_AGENT_NPM_VERSION=0.3.1 aether-agent code "..."self doctornow prints the version it would fetch alongside the launcher's own, so the distinction is visible rather than implied.2. The publish workflow could not run at all
It demanded a release tag — and no tag cut before this launcher existed contains
packages/pypi-cli. A dispatch may now buildmain, which is how the first publish has to happen. A release still publishes from its own immutable tag, and the tag-equals-version check still applies whenever the ref is a tag.Note on the underlying drift
main declaring
0.3.0while npm serves0.3.1is pre-existing and untouched here. This PR makes the launcher correct in spite of it rather than papering over it.🤖 Generated with Claude Code