fix(widget): match mini-chat popup surface to full chat (#16161a) - #901
Merged
Conversation
The dark-mode Jarvis side-chat popup used --jv-surface #1e1d23, a shade lighter than the full chat window's --surface #16161a, so the two chat surfaces looked inconsistent. Align the popup's dark surface token to #16161a. Cosmetic only; light mode unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dark-mode Jarvis side-chat popup (the FAB mini-chat on the Desk) painted its panel background with
--jv-surface: #1e1d23— a shade lighter than the full chat window's--surface: #16161a. The two chat surfaces looked inconsistent side by side.This aligns the popup's dark surface token to
#16161a, so both windows share the same background.Change
jarvis/public/js/jarvis_chat/widget/Panel.vue—.jvp-panel--dark { --jv-surface: #1e1d23 → #16161a }(one line).Scope / safety
#1e1d23occurred exactly once in the whole repo; this is its only reference.--jv-surfacealso backs the online-status dot border, which stays consistent with the new background.bench watchbundle (jarvis_widget.bundle.*.js) recompiled to contain16161aand zero1e1d23, and the rendered popup was visually confirmed to match the full chat.