fix(tests): unbreak CI against upstream Warehouse inventory-account validation - #891
Merged
Merged
Conversation
…ation in the tier2a fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unbreaks CI for every open PR. ERPNext develop (installed fresh by CI) added
Warehouse.validate_inventory_account, which throws when a new Warehouse's company has no default inventory account. The tier2a permission fixture deliberately creates companies without a chart of accounts, so every shard containingtest_tier2a_erpnext_readsnow fails insetUpClass("Please set Account in Warehouse ... or Default Inventory Account in Company ..."). Confirmed on two unrelated PRs (#886, #888) with identical signatures; the same heads were green yesterday.One-line fix: the fixture sets the escape flag upstream provides for exactly this case (
flags.ignore_inventory_account_validation), harmless on older ERPNext. Verified locally with the fixture-exercising class.Pre-merge checklist
testscheck on this PR passes (never merge on ❌)develop