-
Notifications
You must be signed in to change notification settings - Fork 146
[management] Code generation: update services and models #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new terminal management capabilities by adding dedicated models for home screen and kiosk mode configurations. These changes, generated automatically, expand the existing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces automated changes for the management service, adding HomeScreenSettings and KioskModeSettings models and updating TerminalSettings to include them. The code is auto-generated and the changes are consistent with the existing structure. My review focuses on improving the generated documentation for better code clarity and maintainability. I've pointed out areas where the Javadoc for new properties is lacking, which likely stems from missing descriptions in the source OpenAPI specification.
| /** | ||
| * homeScreen | ||
| * | ||
| * @param homeScreen | ||
| * @return the current {@code TerminalSettings} instance, allowing for method chaining | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc for homeScreen is not descriptive. It should explain what this property represents. Since this code is auto-generated, this likely needs to be fixed in the OpenAPI specification by adding a description to the homeScreen property. A good description improves code maintainability and makes the API easier to use.
| /** | ||
| * kioskMode | ||
| * | ||
| * @param kioskMode | ||
| * @return the current {@code TerminalSettings} instance, allowing for method chaining | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains the automated changes for the
managementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.