Skip to content

feat: add showShareButton prop to EventCard and update FavoritesPage to handle event times - #326

Merged
yehiarasheed merged 1 commit into
mainfrom
chore/remove-my-events-share-and-favorites-time
Jan 18, 2026
Merged

yehiarasheed merged 1 commit into
mainfrom
chore/remove-my-events-share-and-favorites-time

Conversation

@yehiarasheed

Copy link
Copy Markdown
Collaborator

This pull request introduces improvements to how event times are displayed and handled across the application, especially for favorites and event cards. It adds support for explicit event start and end times, enhances the logic for formatting and displaying these times, and gives more control over the visibility of the share button in event cards. There are also minor backend adjustments to ensure these new fields are available in API responses.

Event Time Handling and Display:

  • Added support for startTime and endTime fields in the FavoriteEvent interface and included them in API population, allowing explicit storage and retrieval of event times. [1] [2]
  • Improved time formatting logic in the favorites page and event details dialog to display times in 12-hour format and only show derived times from date fields if the time is not midnight. [1] [2]
  • Updated the favorites page to use the new time formatting logic and pass the explicit dbStartTime and dbEndTime to EventCard. [1] [2]

Event Card Enhancements:

  • Added a new showShareButton prop to EventCard, allowing control over whether the share button is displayed, and updated its default and conditional rendering logic accordingly. [1] [2] [3] [4]
  • Set showShareButton={false} for event cards in the "My Events" page, hiding the share button in that context.

Other Minor Changes:

  • Removed an unused variable in the facilities service related to date formatting for bookings.

@yehiarasheed yehiarasheed self-assigned this Jan 18, 2026
@yehiarasheed yehiarasheed added bug Something isn't working backend frontend labels Jan 18, 2026
@github-actions

Copy link
Copy Markdown

Lint & Format summary

  • Prettier: ✅ Passed
  • ESLint: ✅ Passed (0 error(s), 0 warning(s))

How to fix locally:

  • npm run format
  • npm run lint
  • npm run lint:fix (optional)

Notes:

  • The workflow fails on Prettier issues and ESLint errors.
  • ESLint warnings do not fail CI, but are reported here.

@github-actions

Copy link
Copy Markdown

Vercel Preview ✅

This comment is posted automatically after a successful Vercel deployment.

@yehiarasheed
yehiarasheed merged commit 1f0c95e into main Jan 18, 2026
3 checks passed
@yehiarasheed
yehiarasheed deleted the chore/remove-my-events-share-and-favorites-time branch January 18, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant