Skip to content

Fix Give Feedback button logic and remove Reapply from vendor rejected requests - #325

Merged
yehiarasheed merged 2 commits into
mainfrom
fix-feedback-button-and-vendor-reapply
Jan 17, 2026
Merged

yehiarasheed merged 2 commits into
mainfrom
fix-feedback-button-and-vendor-reapply

Conversation

@yehiarasheed

Copy link
Copy Markdown
Collaborator

This pull request introduces improvements to how event feedback actions are displayed in the EventCard component, ensuring feedback is only available for past events with accurate date comparisons. Additionally, it updates the vendor dashboard to remove the ability for users to reapply to rejected applications and clarifies related UI and comments.

Event Feedback Action Improvements:

  • Added a helper function parseEventDateForComparison to accurately determine if an event is in the past, considering both date-only and datetime strings, and preferring endDate when available. This ensures feedback actions are only shown for past events.
  • Updated conditional rendering for feedback actions in EventCard to use the new canShowFeedbackAction logic, improving accuracy and maintainability. [1] [2]

Vendor Dashboard Updates:

  • Removed the "Reapply" button and associated UI from the rejected applications section, so users can no longer reapply after rejection.
  • Updated comments and help text to reflect that reapplying to rejected applications is no longer supported. [1] [2] [3]

…d requests

- Update EventCard to show Give Feedback only for past events using endDate/end-of-day comparison
- Remove Reapply button from VendorDashboard rejected applications tab
@yehiarasheed yehiarasheed self-assigned this Jan 17, 2026
@yehiarasheed yehiarasheed added bug Something isn't working frontend labels Jan 17, 2026
@github-actions

github-actions Bot commented Jan 17, 2026 •

Copy link
Copy Markdown

Lint & Format summary

  • Prettier: ✅ Passed
  • ESLint: ✅ Passed (0 error(s), 1 warning(s))

How to fix locally:

  • npm run format
  • npm run lint
  • npm run lint:fix (optional)

Notes:

  • The workflow fails on Prettier issues and ESLint errors.
  • ESLint warnings do not fail CI, but are reported here.

@github-actions

Copy link
Copy Markdown

Vercel Preview ✅

This comment is posted automatically after a successful Vercel deployment.

@yehiarasheed
yehiarasheed merged commit ba6ff61 into main Jan 17, 2026
3 checks passed
@yehiarasheed
yehiarasheed deleted the fix-feedback-button-and-vendor-reapply branch January 17, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant