[WIP] Update Image-List in Readme#115
Draft
stbischof wants to merge 8 commits intoAdoptOpenJDK:masterfrom
Draft
Conversation
Author
|
@dinogun any wished? Readme
Do you want the size-query.sh script ad commit? |
dinogun
reviewed
Apr 5, 2019
Collaborator
dinogun
left a comment
dinogun
left a comment
There was a problem hiding this comment.
@stbischof Thanks for this PR, really good to be able to get the sizes !
One general comment, it would be good if you can use the functions in common_functions.sh. That way we dont need to maintain this script separately. Please check the main loop in build_latest.sh to get all the variants.
Author
|
give me some days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.