Fix build-site-metadata handling for forked PRs#27
Open
Conversation
Contributor
melissag-ensemble
left a comment
There was a problem hiding this comment.
looped in @timkim first since this overlaps with DEVSITE-2292 - waiting to hear back before reviewing: https://adobeio.slack.com/archives/C03AVNFAA8Y/p1775741260443359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request updates the site metadata workflow to handle forked pull requests more safely and predictably, based on behavior reproduced in AdobeDocs/commerce-php#443 and AdobeDocs/commerce-php#444.
Summary
src/pages/adp-site-metadata.jsonactually changed before attempting any commit or pushnpm run buildSiteMetadatalocally when metadata updates are neededTesting
.github/workflows/build-site-metadata.yml