upgrade jest and add circleCI config#31
Open
bjnish08 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on some dependabot upgrades. There is a vulnerability that couldn't be fixed because of a version mismatch with jest.
After upgrading jest dependencies,
npm installfailed without the-legacy-peer-depsfeature flag. So I regenerated the lockfile by using the right npm version 18.To automatically protect against mismatched packages in the future, I added CI config to run
npm installandnpm test.Changes in the PR
ts-jestand@types/jestupgraded to v29 matchjestTLDR: This PR fixes packages mismatch and also updates the repo to use Node 18 which aligns well with Node and Earl (both use Node 20)