Improve profile role membership UX and harden stale form/session handling#2074
Open
Rvice wants to merge 10 commits into
Open
Improve profile role membership UX and harden stale form/session handling#2074Rvice wants to merge 10 commits into
Rvice wants to merge 10 commits into
Conversation
harden CSRF validation for membership save/stop/remove with fallback token support include fallback CSRF token in profile membership save and delete requests improve membership save error handling (JSON/HTML parsing, clearer timeout/cancel feedback) prevent repeated cancel/reload loops and avoid masking real backend errors add pending/pending-save label fallbacks for missing translations scope post-save reloads to affected membership sections only (plus cross-bucket target when needed) stop global full-role refresh on messagebox close to avoid unnecessary current/former/future reloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the profile role membership experience by replacing disruptive reloads with inline updates, preserving in-progress edits more reliably, and fixing several stale token/session edge cases uncovered during testing.
Highlights
User-facing improvements
Stability fixes
Internal cleanup
Testing
Validated with targeted syntax checks on the touched PHP files, including mirrored deployment copies where applicable.